Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply automated cargo clippy --fix #69

Merged
merged 7 commits into from
Feb 22, 2024
Merged

apply automated cargo clippy --fix #69

merged 7 commits into from
Feb 22, 2024

Conversation

yoshuawuyts
Copy link
Contributor

No description provided.

@yoshuawuyts
Copy link
Contributor Author

oh right, we're testing 1.39 in CI. Though we don't advertise an MSRV, I don't want to think about loosening that right now. Closing this now.

otherwise CI doesn't build
@yoshuawuyts yoshuawuyts reopened this Feb 22, 2024
@yoshuawuyts
Copy link
Contributor Author

Retrying this; apparently our deps depend on Rust 1.56 or higher - so we need to bump the CI version anyway. That's fine; updating.

@yoshuawuyts
Copy link
Contributor Author

The reason for this patch is that #66 was just merged; and I want to make sure that the main branch has a passing CI before doing a release. That requires among other things disabling the "warnings === errors" check, and for good measure we've also applied a cargo clippy --fix pass to update the code.

@yoshuawuyts
Copy link
Contributor Author

Seems like it needs 1.60 as a minimum. Bumped!

@yoshuawuyts
Copy link
Contributor Author

We went from Rust 1.39 to 1.63 as a minimum. At this point we might as well drop trying to test for older Rust versions given we don't guarantee an MSRV anyway. This shouldn't break any code right now, but should at least ensure that our CI stops breaking (because our dependencies don't guarantee an MSRV either).

@yoshuawuyts yoshuawuyts merged commit 8804b75 into master Feb 22, 2024
8 checks passed
@yoshuawuyts yoshuawuyts deleted the cargo-fix branch February 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant