Limits #3
Merged
Limits #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the traits to support limiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes the
limitfunctionality outlined in #1. This only updates the traits to contain the functionality, and provide the methods. It does not yet enforce the limits, however.The impl on how to enforce it is probably to create a stream wrapper that returns a tuple of
(item, guard)that increments an internal counter if a limit has been set. Then when the guard is dropped, using anAtomicWakerit can wake the stream up to continue polling (while checking capacity).Either way, this is a required first step to get us forward. Thanks!