Updates all Tier 1 BSP examples to use RTIC v2 and the RTC monotonic where applicable #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…monotonic where applicable
* Ensures that all Tier 1 BSPs have all examples listed in Cargo.toml in alphabetical order.
* Tier 1 BSP changes:
* samd11_bare
* Adds the `blinky_rtic` example.
* metro_m0
* Updates the `blinky_rtic` example to use RTIC v2 and the RTC monotonic.
* feather_m0
* Updates the `blinky_rtic` example to use the RTC monotonic.
* Renames the `blinky_monotonic` example to `blinky_embassy`, which is more apt since they both use a monotonic.
* Updates the `blinky_embassy` example to use the RTC monotonic as well, showing that this can be done despite it being a monotonic written for RTIC.
* pygamer
* Adds the `blinky_rtic` example.
* metro_m4
* Adds the `blinky_rtic` example.
* feather_m4
* Adds the `blinky_rtic` example.
* Updates the `clocking_v2` example to use RTIC v2.
* atsame54_xpro
* Updates the `blinky_rtic` example to use RTIC v2 and the RTC monotonic.
* Updates the `mcan` example to use RTIC v2 and the RTC monotonic.
|
Good stuff, thanks @kyp44. Is there any more work to be done in this PR or is it ready to merge? |
|
Thanks! It's ready to merge as far as I am concerned. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some Tier 1 BSP RTIC examples used RTIC v1 and others v2. When delays are required, they all used the inefficient SysTick monotonic.
This updates all Tier 1 BSP RTIC examples to use RTIC v2 and the recently released RTC monotonic instead. It also ensures that all Tier 1 BSPs feature at least one RTIC example, adding a
blinky_rticexample as needed.See the commit message for details on what was done for each BSP.
Note that I was only able to test the example changes for the
metro_m0andpygamerBSPs. If others are able/willing to test on other boards that would definitely be a good thing.Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.