-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle MP3 files with soundfile #145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the update, unfortunately, I'm not quite sure what the update does.
The main change is that we require a newer soundfiles version and that all tests and benchmarks are updated accordingly, right?
Yes, we require import soundfile
soundfile.__libsndfile_version__
In addition, it updates the tests as MP3 was used in some tests to represent an audio format not supported by And the most files were changed as part of the updated benchmark pages, which now include the results for the changes of this pull request. |
Okay, great, makes a lot of sense to me! |
Closes #119
This adds reading and metadata support for MP3 files using
soundfile >=0.11.0
soundfile>=0.12.1
.I have not added writing support for MP3 files
as this depends on the system wide installation oflibsndfile
(compare bastibe/python-soundfile#348), whereas for reading thelibsndfile
library bundled withsoundfile
is used (hence the dependency onsoundfile>=0.11.0
soundfile>=0.12.1
).If we think writing support for MP3 is needed as well, I would propose to add it in another pull request.
It also updates the benchmark page with the new results.
For the "Reading files" benchmark it presents now all results in a single figure. For the "Accessing metadata" benchmark,
results for MP4 are still shown in an extra figure as it takes much longer than for the other formats.
The good news is that the proposed changes make processing of MP3 faster (results as average per file):
Benchmark page
/cc @frankenjoe