Updating default audience config values and logic #382
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchang16-auth
commented
Feb 27, 2025
| feature of{" "} | ||
| using the default value of{" "} | ||
| <code>{yourApiIdentifier}</code>. You might get this | ||
| default value if you used the "Download Sample" feature of{" "} | ||
| <a href="https://auth0.com/docs/quickstart/spa/react"> | ||
| the quickstart guide | ||
| </a> |
There was a problem hiding this comment.
Here I had to use the HTML characters for {}, as it was considering the brackets as JSX and causing the tests to fail.
wdaimee
reviewed
Feb 28, 2025
| @@ -14,7 +14,7 @@ const appOrigin = authConfig.appOrigin || `http://localhost:${appPort}`; | |||
| if ( | |||
| !authConfig.domain || | |||
| !authConfig.audience || | |||
| authConfig.audience === "YOUR_API_IDENTIFIER" | |||
| ["{yourApiIdentifier}", "{API_IDENTIFIER}"].includes(authConfig.audience) | |||
There was a problem hiding this comment.
Can "{API_IDENTIFIER}" be passed as a default value? I am just wondering where this is coming from as "{yourApiIdentifier}" seems to be the default value.
There was a problem hiding this comment.
I just looked at some python sample apps and saw that they have "{API_IDENTIFIER}" as the default value for API_IDENTIFIER. Please disregard the above comment.
daniellercole
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"YOUR_API_IDENTIFIER"->"{yourApiIdentifier}". Currently, if a user downloads the Auth0 Angular sample app without an API, the downloaded sample app has itsaudiencevalue in auth_config.json set to"{yourApiIdentifier}". This is because"YOUR_API_IDENTIFIER"is no longer the default value, as it has been swapped with"{yourApiIdentifier}".Supporting References