Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring phone provider #1137

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Feb 17, 2025

Auth0 provides integration capabilities with many phone providers like custom, twilio etc.
As an extension to this, it now also supports Custom Phone Provider which is tied to an action.

🔧 Changes

Add auth0 phone provider commands:

  • auth0 phone provider show
  • auth0 phone provider create
  • auth0 phone provider update
  • auth0 phone provider delete

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

go.mod Outdated
@@ -8,7 +8,7 @@ replace github.com/mholt/archiver/v3 => github.com/anchore/archiver/v3 v3.5.2
require (
github.com/AlecAivazis/survey/v2 v2.3.7
github.com/PuerkitoBio/rehttp v1.4.0
github.com/auth0/go-auth0 v1.16.0
github.com/auth0/go-auth0 v1.16.1-0.20250212051907-88b14d38822d

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use release version

Copy link

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test check are not passing please check

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 69.50959% with 143 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (35776ca) to head (d25dc86).

Files with missing lines Patch % Lines
internal/cli/phone_provider.go 69.28% 65 Missing and 21 partials ⚠️
internal/display/phone_provider.go 62.50% 28 Missing and 5 partials ⚠️
internal/display/event_streams.go 65.11% 10 Missing and 5 partials ⚠️
internal/cli/terraform_fetcher.go 83.33% 2 Missing and 1 partial ⚠️
internal/display/display.go 66.66% 2 Missing and 1 partial ⚠️
internal/cli/terraform.go 0.00% 2 Missing ⚠️
internal/cli/event_streams.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   70.60%   70.58%   -0.03%     
==========================================
  Files          98      101       +3     
  Lines       14029    14433     +404     
==========================================
+ Hits         9905    10187     +282     
- Misses       3526     3621      +95     
- Partials      598      625      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya18101 ramya18101 marked this pull request as ready for review February 25, 2025 08:15
@ramya18101 ramya18101 requested a review from a team as a code owner February 25, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants