Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-581 # preliminary work for Java 17 support - updating maven dependencies #594

Closed
wants to merge 20 commits into from
Closed

ISSUE-581 # preliminary work for Java 17 support - updating maven dependencies #594

wants to merge 20 commits into from

Conversation

baulea
Copy link
Contributor

@baulea baulea commented Oct 21, 2023 •
edited
Loading

ISSUE-581 # preliminary work for Java 17 support - updating maven dependencies

PR Branch
https://github.com/baulea/zerocode/tree/feature/java17

Motivation and Context

Updated maven dependencies to versions that are more up-to-date. This is preliminary work for Java 17 support. I'll continue with work for Java 17 support.

"mvn clean install" succeeded with all tests

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced

  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow

  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@baulea
Use maven-compiler-plugin.version for http-testing junit5-testing and
d648962 
kafka-testing to avoid maven warnings like
[WARNING] Some problems were encountered while building the effective
model for org.jsmart:http-testing:jar:1.3.36-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 50,
column 21
[WARNING]
@baulea
upgrade to guice-5.1.0 for Java 17 support and log exceptions during
2414304 
creating of guice injector
@baulea
Upgrade versions for maven-compiler-plugin and maven-assembly-plugin
6bd984f
@baulea
remove compiler warnings
4f7474a 
[WARNING] /home/alois/eclipse-workspace-zerocode/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[102,62] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Class<?> for a varargs call
  cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning
[WARNING] /home/alois/eclipse-workspace-zerocode/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[103,50] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Object for a varargs call
  cast to java.lang.Object[] for a non-varargs call and to suppress this warning

[WARNING] /home/alois/eclipse-workspace-zerocode/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/executor/javaapi/JavaMethodExecutorImplTest.java:[90,83] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Object for a varargs call
  cast to java.lang.Object[] for a non-varargs call and to suppress this warning
[WARNING] /home/alois/eclipse-workspace-zerocode/zerocode/core/src/test/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRuntimeAnnoTest.java:[57,78] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Class<?> for a varargs call
  cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning
@baulea
Use java-compiler-source.version and java-compiler-target.version eve…
54e9424 
…rywhere
@baulea
Remove deprecated constructors
e1325ec
@baulea
Correct indenting
9aec3cb
@baulea
Upgrade from org.apache.commons.commons-lang to org.apache.commons.co…
a60293f 
…mmons-lang3
@baulea
replace org.apache.commons.lang with org.apache.commons.lang3 and org…
7dbaf86 
….apache.commons.text
@baulea
replace org.apache.commons.lang with org.apache.commons.lang3 and org…
86221df 
….apache.commons.text
@baulea
update jackson-dataformat-yaml to 2.11.0, gson to 2.10.1 and google.p…
f0d2336 
…rotobuf to 3.24.4
@baulea
update jackson-databind to 2.11.0, jsonassert to 1.5.1, jukito to 1.5…
7829fc4 
…, jayway to 2.7.0
@baulea
update guava.version to 32.1.3-jre
257c696
@baulea
update commons-io to 2.14.0
72ad618
@baulea
update httpclient to 5.2.1
fbeb5bb
@baulea
update maven plugins
88699be 
maven-source-plugin 3.3.0, maven-javadoc-plugin 3.6.0, maven-gpg-plugin 3.1.0, maven-release-plugin 3.0.1, maven-surefire-plugin 3.1.2
@baulea
update logback to 1.3.11
48ec421
@baulea
update json-path to 2.8.0
6d2daf1
@baulea
update resteasy-jaxrs to 3.15.6.Final
29c211f
@baulea
update wiremock to 2.27.2 and correct one integration-test: "urlPath"…
0693701 
…->"url"
@baulea
Copy link
Contributor Author

baulea commented Oct 26, 2023

With JDK17 I didn't get a successful maven build with the current authorjapps:master branch. I thought it a good idea -- instead of debugging problems -- to start with updating a bunch of maven dependencies - e.g. a guice version >=5.1.0 is needed for Java17 support (https://github.com/google/guice/wiki/Guice510). And so this pull request was born.

Should I break up this pull request into smaller chunks and create a separate issue and pull request for each chunk? Or are you generally cautious about updating maven dependencies and we should keep our hands off?

@baulea
Copy link
Contributor Author

baulea commented Oct 27, 2023

I'll better break this into smaller chunks and create issues for each one.

@baulea baulea closed this Oct 27, 2023
@baulea baulea deleted the feature/java17 branch October 27, 2023 17:50
@authorjapps
Copy link
Owner

With JDK17 I didn't get a successful maven build with the current authorjapps:master branch. I thought it a good idea -- instead of debugging problems -- to start with updating a bunch of maven dependencies - e.g. a guice version >=5.1.0 is needed for Java17 support (https://github.com/google/guice/wiki/Guice510). And so this pull request was born.

Should I break up this pull request into smaller chunks and create a separate issue and pull request for each chunk? Or are you generally cautious about updating maven dependencies and we should keep our hands off?

Hello @baulea , appreciate you were looking into this in terms of updating the dependenct libraries 1st.
But can you please make sure it hangs together well with JDK8 builds and it doesn't break anything.
Once this is assured, we can think of the next step for JDK17 support.

I think it's better to create a separate module(if possible) for JDK 17 migration related works.
But I am not sure even if that's possible or we need a completely separate project.

@baulea
Copy link
Contributor Author

baulea commented Oct 28, 2023

Thank you very much for your reply. And thanks for sharing the goal to support JDK17.
My current pull request on updating maven dependencies was a bit mixed-up indeed (and therefore I closed the pull request myself). I fixated on a successful maven build and that the provided tests ran successfully (with JDK8). I only had a slight glance at conflicting dependencies and it seemed ok, but I did not cross check these conflicts.
So I'll concentrate on filing smaller chunks of updates that are easier to check. Thank you for your patience :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baulea @authorjapps