Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #207] Implementing Feature : Meta Data section (Scenario JSON) #674

Merged

Conversation

prayascoriolis
Copy link
Contributor

@prayascoriolis prayascoriolis commented Aug 20, 2024

WIP: [Issue #207 ] Implementing feature: Meta Data section in Scenario Json

Fixes Issue

  • Which issue or ticket was(will be) fixed by this PR? (207)

PR Branch
https://github.com/prayascoriolis/zerocode/tree/ISSUE-207-Meta-Data-Section

Motivation and Context

  • So far, I've completed following changes:
  1. Implemented the unit test case associated with the issue which includes a java test file in http-testing and an assertions json file in resources which contains the meta data.
  2. Updated ScenarioSpec.java to include a meta field of type Map<String, List>.
  3. Modified ZeroCodeCsvReport.java to add new fields: metaAuthors, metaTickets, metaCategories, and metaOthers.
  4. Updated ZeroCodeCsvReportBuilder.java to include builder methods for the new meta data fields.
  5. For ZeroCodeExecResult.java: Added a new field private Map<String, List> meta; and corresponding getter/setter methods to store and retrieve meta data for each execution result.
  6. ZeroCodeReportGeneratorImpl.java: added logic to include meta data in the Extent report generation, CSV schema, and CSV row building processes, ensuring meta information is captured in both HTML and CSV reports.

Checklist:

  • New Unit tests were added

  • Integration tests were added

  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. The changes did not affect HTTP automation flow

    • Not applicable. The changes did not affect Kafka automation flow

… in the scenario JSON (unit test java file and assertion json file added)
@prayascoriolis prayascoriolis changed the title WIP: [Issue #207] Implementing Feature : Meta Data section in the sce… WIP: [Issue #207] Implementing Feature : Meta Data section (Scenario JSON) Aug 21, 2024
@prayascoriolis prayascoriolis changed the title WIP: [Issue #207] Implementing Feature : Meta Data section (Scenario JSON) [Issue #207] Implementing Feature : Meta Data section (Scenario JSON) Sep 12, 2024
@nirmalchandra
Copy link
Collaborator

resources

@prayascoriolis, can you make these two lower case letters?
(just to be consistent with other folders and files)

@prayascoriolis
Copy link
Contributor Author

resources @prayascoriolis, can you make these two lower case letters? _(just to be consistent with other folders and files)_

@nirmalchandra thankyou, i made those changes.

@nirmalchandra
Copy link
Collaborator

Looks like you're unsure about naming conventions for Java.

Try to have a look here:
https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html

  • Then please correct the below class name and anyother things you're trying to modify.

We won't be able to approve or merge the PR till then.


http-testingsrctest

@prayascoriolis
Copy link
Contributor Author

Looks like you're unsure about naming conventions for Java.

Try to have a look here: https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html

  • Then please correct the below class name and anyother things you're trying to modify.

We won't be able to approve or merge the PR till then.

http-testingsrctest

Thanks, I fixed the class name and resubmitted the PR.

@nirmalchandra nirmalchandra merged commit f52682f into authorjapps:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants