-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #207] Implementing Feature : Meta Data section (Scenario JSON) #674
[Issue #207] Implementing Feature : Meta Data section (Scenario JSON) #674
Conversation
… in the scenario JSON (unit test java file and assertion json file added)
… in the scenario JSON (unit test java file and assertion json file added)
…o ISSUE-207-Meta-Data-Section
@prayascoriolis, can you make these two lower case letters? |
@prayascoriolis, can you make these two lower case letters? _(just to be consistent with other folders and files)_ @nirmalchandra thankyou, i made those changes. |
Looks like you're unsure about naming conventions for Java. Try to have a look here:
We won't be able to approve or merge the PR till then. |
Thanks, I fixed the class name and resubmitted the PR. |
WIP: [Issue #207 ] Implementing feature: Meta Data section in Scenario Json
Fixes Issue
PR Branch
https://github.com/prayascoriolis/zerocode/tree/ISSUE-207-Meta-Data-Section
Motivation and Context
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
Branch build passed in CI
No 'package.*' in the imports
Relevant DOcumentation page added or updated with clear instructions and examples for the end user
Not applicable. The changes did not affect HTTP automation flow
Not applicable. The changes did not affect Kafka automation flow