Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Split out MakeMKV Version into Seperate File #390

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[FEATURE] Split out MakeMKV Version into Seperate File #390

wants to merge 15 commits into from

Conversation

microtechno9000
Copy link
Collaborator

@microtechno9000 microtechno9000 commented Mar 2, 2025 •
edited
Loading

Feature

  • Split MakeMKV version to VERSION_MAKEMKV
  • Added GitHub workflow that checks version each midnight UTC
  • If a new version of MakeMKV is found will raise a PR before incrementing the version. MakeMKV version history is pulled from the version info web page
  • Updated the GitHub version bump to only run on a PR completion not each commit (as can see from the version history, GitHub keeps auto incrementing each commit.

Tested locally using docker build, no issues seen

Tested using GitHub where possible, Docker container build didn't work due to local fork not having docker keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shitwolfymakes shitwolfymakes Awaiting requested review from shitwolfymakes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microtechno9000