Change default CLI values for blocks and state pruning to and make in valid value for state pruning non-representable #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valid value for state pruning non-representable
nazar-pc
requested review from
vedhavyas,
jim-counter,
NingLin-P and
EmilFattakhov
vedhavyas
reviewed
Feb 5, 2024
| /// - archive-canonical Keep only finalized blocks. | ||
| /// - number: Keep the last `number` of finalized blocks. | ||
| #[arg(long, default_value_t = BlocksPruningMode::Number(256))] | ||
| blocks_pruning: BlocksPruningMode, |
There was a problem hiding this comment.
Shouldn't we also include a check to not let user specify < 256 for some reason or is that not a requirement ?
There was a problem hiding this comment.
Not a requirement, it is a somewhat arbitrary number
Base automatically changed from
require-force-authoring-for-genesis-farmer
to
main
February 5, 2024 06:18
vedhavyas
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subspace doesn't support state pruning the same way as many other Substrate chains because of the need to query state of older blocks for archiving, hence default state pruning of Substrate of 256 blocks is broken for Subspace (impossible to restart node after this).
Once user rightfully pointed this out and I decided to change the defaults accordingly. Instead of archive-canonical/256 for blocks and state pruning we now have 256/archive-canonical instead. Also state pruning in blocks is no longer specifiable.
This will be improved once we can prune things programmatically (see paritytech/polkadot-sdk#1570).
As the result of these changes, some CLI options no longer need to be specified explicitly by farmers.
Code contributor checklist: