Simplify local network struct #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs and
michaelkaplan13
iansuvak
approved these changes
Nov 12, 2024
| @@ -41,16 +33,12 @@ import ( | |||
|
|
|||
| // Implements Network, pointing to the network setup in local_network_setup.go | |||
| type LocalNetwork struct { | |||
| primaryNetworkInfo *interfaces.SubnetTestInfo | |||
| subnetsInfo map[ids.ID]*interfaces.SubnetTestInfo | |||
| tmpnet.Network | |||
There was a problem hiding this comment.
Thanks for making this change! Love it.
geoff-vball
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Cleans up the
LocalNetworkstruct to act as an extension totmpnet.How this works
LocalNetworkwithtmpnet.Network, rather than owning an instance. This automatically exposes alltmpnet.Networkmethods, allowing for greater flexibility.LocalNetworktoTeleporterTestInfoTeleporterTestInfomethods.SubnetTestInfoon demand, removing the need to consider stale state when modifying the network.How this was tested
CI
How is this documented
N/A