fix: gracefully handle logName on undefined Arn #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbusato-ts
approved these changes
Jul 12, 2022
|
@josephvusich could you help us get this fix merged? |
leoherran-aws
approved these changes
Jul 13, 2022
subinataws
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #98
Description of changes:
Apparently when triggering CodeBuild jobs we expected that the initial response to
startBuildwould includelogs.cloudWatchLogsArn. Maybe AWS updated their APIs, but the matter of fact is that this is no longer the case and the Arn won't be available during the provisioning phase of the CodeBuild project instance. This means that everyone currently using this action is getting anCannot read property 'split' of undefinedwhen trying to grab the log group and log stream.This PR adds a conditional check in case Arn is not available yet so it returns undefined log-group and log-stream. A test case was also added to validate the behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: