Make aws-region optional #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwoodworth
suggested changes
Mar 15, 2023
| @@ -287,7 +287,7 @@ async function run() { | |||
| const accessKeyId = core.getInput('aws-access-key-id', { required: false }); | |||
| const audience = core.getInput('audience', { required: false }); | |||
| const secretAccessKey = core.getInput('aws-secret-access-key', { required: false }); | |||
| const region = core.getInput('aws-region', { required: true }); | |||
| const region = core.getInput('aws-region', { required: true }) || process.env.AWS_REGION || process.env.AWS_DEFAULT_REGION; | |||
There was a problem hiding this comment.
Set required: false 🙂
| expect(core.exportVariable).toHaveBeenCalledWith("AWS_REGION", "fake-default-region") | ||
| expect(core.exportVariable).toHaveBeenCalledWith("AWS_DEFAULT_REGION", "fake-default-region") | ||
| }) | ||
|
|
There was a problem hiding this comment.
I'd like two more tests here:
One to make sure that when the action input, and both AWS_REGION and AWS_DEFAULT_REGION are all set, the action will prefer the action input value over all others.
Another test to verify that when both AWS_REGION and AWS_DEFAULT_REGION are set, it prefers AWS_REGION
|
I'm going to be closing this - we want to think about how to best accomplish this while considering the option to use global endpoints. We're working on the next version which will be using js v3, meaning the implementation of this feature would look different there, and we'll be including the option to use global endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Makes region optional and falls back to
AWS_REGIONandAWS_DEFAULT_REGIONtaken from this previous discussionMake region optional #431 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.