Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow s3 cors options to be configured #1972

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukebellamy053
Copy link

@lukebellamy053 lukebellamy053 commented Sep 8, 2024

Problem

Currently there is no nice way of setting the CORS configuration of an S3 bucket without using CloudFormation templates and escape hatches

The core problem here is that the default CORS options do not expose amzn-meta-* headers which means meta data is useless to a frontend consumer

Changes

Added the option to define a CORSRule array at the defineStorage level, if present, this will be used over the default

Validation

Added a unit test that validates the CORS settings are applied to the CDK template when the option is set
There is already a unit test that validates the default CORS options are used when the setting is not provided

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lukebellamy053 lukebellamy053 requested review from a team as code owners September 8, 2024 17:19
Copy link

changeset-bot bot commented Sep 8, 2024

🦋 Changeset detected

Latest commit: d5e3ff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant