Renamed map and mapper properties to __map and __mapper, to avoid conflicts with graphql schemas containing those properties #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… problem with Graphql schemas having those properties breaking the simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR addresses the issue reported in aws-amplify/amplify-category-api#1676, where any valid Graphql schema containing a property called either
mapormapperwill crash without error in the appsync simulator.Issue #, if available
aws-amplify/amplify-category-api#1676
Description of how you validated changes
The problem is that the velocity implementation stores the graphql data in an object that also has private objects called generic names. The fix is to name them with a double-underscore to indicate they are not part of userland payloads.
Testing
I have run the current test suite, but have not written a new test for this change.
I have also been using this locally on a production schema for a few months and it's working as intended. In fact, I rely upon it :-)
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.