Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Enable resumable SignIn #13483

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Jun 7, 2024

Description of changes

  • Enable v6 users to have an option to continue SignIn process after a full browser reload by storing, then utilizing session in session storage

Issue #, if available

Description of how you validated changes

  • Unit tests (IP)
  • Smoke Test on sample application

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joon-won . We are getting close. A couple of things,

  1. we should consider creating an internal sync sessionStorage util so we don't have to change the sync behavior of the signInStore

  2. we must avoid modifying state at all costs. Left comments bellow and pointed out the tests needed

@joon-won joon-won marked this pull request as ready for review June 20, 2024 20:50
cshfang
cshfang previously approved these changes Aug 22, 2024
israx
israx previously approved these changes Aug 23, 2024
jimblanc
jimblanc previously approved these changes Aug 23, 2024
packages/aws-amplify/jest.config.js Outdated Show resolved Hide resolved
@joon-won joon-won dismissed stale reviews from jimblanc, israx, and cshfang via deb0d9d August 23, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants