Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not automatically retry on serverside errors #13641

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Should not automatically retry on serverside errors #13641

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cba3174
Should not automatically retry on serverside errors
Jul 24, 2024
4ea8367
Stop automatically retrying on serverside errors
Jul 24, 2024
1ded490
Merge branch 'main' into main
daixi98 Aug 12, 2024
e50fdab
Merge branch 'main' into main
daixi98 Aug 18, 2024
9913bd5
Merge branch 'main' into main
daixi98 Aug 26, 2024
cb4f89c
Merge branch 'main' into main
daixi98 Sep 5, 2024
1ef3e4f
Merge branch 'main' into main
daixi98 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/src/clients/middleware/retry/defaultRetryDecider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const getRetryDecider =
isConnectionError(error) ||
isThrottlingError(statusCode, errorCode) ||
isClockSkewError(errorCode) ||
isServerSideError(statusCode, errorCode)
isServerSideTimeoutError(errorCode)
);
};

Expand Down Expand Up @@ -57,6 +57,5 @@ const isThrottlingError = (statusCode?: number, errorCode?: string) =>
const isConnectionError = (error?: unknown) =>
(error as Error)?.name === 'Network error';

const isServerSideError = (statusCode?: number, errorCode?: string) =>
(!!statusCode && [500, 502, 503, 504].includes(statusCode)) ||
(!!errorCode && TIMEOUT_ERROR_CODES.includes(errorCode));
const isServerSideTimeoutError = (errorCode?: string) =>
!!errorCode && TIMEOUT_ERROR_CODES.includes(errorCode);