Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ui to storage browser co-owner #13694

Open
wants to merge 1 commit into
base: storage-browser/main
Choose a base branch
from
Open

chore: add ui to storage browser co-owner #13694

wants to merge 1 commit into from

Conversation

AllanZhengYP
Copy link
Member

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner August 8, 2024 00:55
ashika112
ashika112 reviewed Aug 8, 2024
View reviewed changes
.github/CODEOWNERS
@@ -8,6 +8,8 @@
/packages/geo @aws-amplify/amplify-js @aws-amplify/amplify-ui
/packages/pubsub @aws-amplify/amplify-js @aws-amplify/amplify-data
/packages/aws-amplify/package.json @aws-amplify/amplify-js-admins
packages/storage/src/storageBrowser @aws-amplify/amplify-js @aws-amplify/amplify-ui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have slash in the beginning to match the other ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashika112 ashika112 ashika112 left review comments

@jimblanc jimblanc jimblanc approved these changes

@calebpollman calebpollman calebpollman approved these changes

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllanZhengYP @jimblanc @calebpollman @ashwinkumar6 @ashika112