feat(adapter-nextjs): server-side auth flows integrating cognio hosted UI #13827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
a team
as code owners
HuiSF
commented
Sep 19, 2024
| "alwaysStrict": true | ||
| "alwaysStrict": true, | ||
| "lib": [ | ||
| "esnext" |
There was a problem hiding this comment.
The base tsconfig has jsdom as a lib, that makes origin variable a legit global variable which is not desired.
HuiSF
commented
Sep 19, 2024
HuiSF
commented
Sep 19, 2024
ashika112
changed the title
HuiSF
force-pushed
the
hui/feat/adapter-nextjs/3-auth-api-handlers-impl
branch
from
6087817
to
ae36b32
Compare
HuiSF
commented
Sep 19, 2024
Comment on lines
+61
to
+63
| path: '/', | ||
| httpOnly: true, | ||
| secure: true, |
There was a problem hiding this comment.
These three attributes are not configurable.
HuiSF
force-pushed
the
hui/feat/adapter-nextjs/3-auth-api-handlers-impl
branch
from
ae36b32
to
621d0cb
Compare
HuiSF
force-pushed
the
hui/feat/adapter-nextjs/2-auth-api-handlers
branch
from
25c4eaa
to
26ec9ed
Compare
HuiSF
force-pushed
the
hui/feat/adapter-nextjs/3-auth-api-handlers-impl
branch
from
621d0cb
to
284acbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implemented the following flow integrating Cognito Hosted UI endpoints:
API Route handlers work with both Next.js App Router and Pages Router.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ide auth…ide auth…ide auth