Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stroage): add foundation CopyObjectClient #13829

Open
wants to merge 1 commit into
base: ashwin/storage-browser/foundation/base
Choose a base branch
from
Open

refactor(stroage): add foundation CopyObjectClient #13829

wants to merge 1 commit into from

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Sep 19, 2024 •
edited
Loading

Description of changes

  • Refactor to add foundation CopyObject client
  • add factories for CopyObjectClient, Serializer and Deserializer
  • Update internal/copy to use new foundation client

Description of how you validated changes

Tested copy API locally on test app

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…correct metadata…correct metadata…correct metadata

@ashwinkumar6 ashwinkumar6 changed the title chore(CreateDeleteObjectDeserializer): expect deserializer to return … eat(stroage): add foundation CopyObjectClient Sep 19, 2024
@ashwinkumar6 ashwinkumar6 changed the title eat(stroage): add foundation CopyObjectClient feat(stroage): add foundation CopyObjectClient Sep 19, 2024
@ashwinkumar6 ashwinkumar6 changed the title feat(stroage): add foundation CopyObjectClient refactor(stroage): add foundation CopyObjectClient Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukhan-amazon ukhan-amazon Awaiting requested review from ukhan-amazon ukhan-amazon is a code owner

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@jimblanc jimblanc Awaiting requested review from jimblanc jimblanc is a code owner

@HuiSF HuiSF Awaiting requested review from HuiSF HuiSF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ashwinkumar6