-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update example and demo copy buttons #2078
chore(docs): update example and demo copy buttons #2078
Conversation
|
if it's only docs change, we don't add changelog |
👍 Can we configure the |
Not yet, I opened a feature request on their repo: changesets/bot#44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛥️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this task up!
Description of changes
Updates to the copy buttons used in the demo and example code blocks:
CopyButton
Screenshots
Extra space below horizontal scroll bar. overlap of copy button on horizontal scroll bar:
Before:
After:
Example text visible through copy button:
Copy button spacing when vertical scroll bar visible:
Before:
After:
Issue #, if available
#1905 (comment)
Description of how you validated changes
Manual testing
Checklist
yarn test
passessideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.