Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update example and demo copy buttons #2078

Merged

Conversation

calebpollman
Copy link
Member

Description of changes

Updates to the copy buttons used in the demo and example code blocks:

Screenshots
Extra space below horizontal scroll bar. overlap of copy button on horizontal scroll bar:
Before:
image

After:
image

Example text visible through copy button:

image

image

Copy button spacing when vertical scroll bar visible:

Before:
image

After:
image

Issue #, if available

#1905 (comment)

Description of how you validated changes

Manual testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2022

⚠️ No Changeset found

Latest commit: 74651e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Jun 11, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Jun 11, 2022
@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Jun 11, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Jun 11, 2022
@0618
Copy link
Contributor

0618 commented Jun 11, 2022

if it's only docs change, we don't add changelog

@calebpollman
Copy link
Member Author

if it's only docs change, we don't add changelog

👍 Can we configure the changeset-bot to not run on docs updates?

@wlee221
Copy link
Contributor

wlee221 commented Jun 11, 2022

👍 Can we configure the changeset-bot to not run on docs updates?

Not yet, I opened a feature request on their repo: changesets/bot#44

@calebpollman calebpollman added the run-tests Adding this label will trigger tests to run label Jun 11, 2022
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Jun 11, 2022
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥️

@calebpollman calebpollman temporarily deployed to ci June 11, 2022 22:11 Inactive
@calebpollman calebpollman temporarily deployed to ci June 11, 2022 22:11 Inactive
@calebpollman calebpollman temporarily deployed to ci June 11, 2022 22:11 Inactive
@calebpollman calebpollman temporarily deployed to ci June 11, 2022 22:11 Inactive
Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this task up!

@calebpollman calebpollman merged commit b1d983c into aws-amplify:main Jun 13, 2022
@calebpollman calebpollman deleted the docs/code-copy-button-updates branch June 13, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants