a11y- Use nested list for <h3> links within the table of contents #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbuchel
reviewed
Aug 12, 2024
| subheadings: [] | ||
| }); | ||
| } else if (innerText && id && localName == 'h3') { | ||
| headings[headings.length - 1].subheadings.push({ |
There was a problem hiding this comment.
Oh, I missed this during my review. This is causing the console error check to fail. It's on pages that don't have a parent h2 because they have improper heading structure.
There was a problem hiding this comment.
Fixed the improper heading structure throughout.
katiegoines
requested review from
hdworld11,
dbanksdesign,
aspittel and
josefaidt
as code owners
jacoblogan
previously approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
[Issue] There is content that appears as a nested list but does not use nested list markup.
[Fix] Nest h3 headings under their parent h2 in table of contents
Staging: https://a11y-toc-nested.d1egzztxsxq9xz.amplifyapp.com/react/start/quickstart/
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.