Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blocky text for Windows users #7913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph082
Copy link

@joseph082 joseph082 commented Aug 23, 2024

Description of changes:

Fixes blocky text for Windows users by updating the Amazon Ember font version from 0.002 to 1.010.

Updated font files are from https://m.media-amazon.com/images/G/01/mobile-apps/dex/alexa/branding/Amazon_Typefaces_Complete_Font_Set_Mar2020.zip, which is linked on https://developer.amazon.com/en-US/alexa/branding/echo-guidelines/identity-guidelines/typography.

Before:
image
image
The above screenshot is of docs.amplify.aws/react/how-amplify-works/concepts/. The bottom ends of the S and s's are blocky. Other parts in the screenshot and text on other pages are also pixelated.

After:
image
image
The bottom ends of the S and s's aren't blocky anymore.

Alternatives considered:
I tried fixing this with CSS, but I couldn't find a combination that worked. My friends on MacOS and Linux also didn't see the blocky text on their screens, which hints to an OS/font issue instead of a browser/CSS issue.

Related GitHub issue #, if available:

Fixes #2696
I saw this issue on both Windows 10 and 11, on Chrome and Firefox.

Instructions

Which product(s) are affected by this PR (if applicable)?

  • Docs

Checks

  • Does this PR conform to the styleguide?
  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
  • Are any files being deleted with this PR? If so, have the needed redirects been created?
  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joseph082 joseph082 requested a review from a team as a code owner August 23, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts used in the docs is creating artifacts on normal zoom level
1 participant