Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Fn::Transform alongside keys in mappings #3920

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3916

Description of changes:

  • Allow Fn::Transform alongside keys in mappings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (5d9282d) to head (0e3e981).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
- Coverage   93.81%   93.81%   -0.01%     
==========================================
  Files         366      366              
  Lines       12536    12538       +2     
  Branches     2579     2580       +1     
==========================================
+ Hits        11761    11762       +1     
  Misses        429      429              
- Partials      346      347       +1     
Flag Coverage Δ
unittests 93.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 83fd95a into aws-cloudformation:main Jan 17, 2025
24 checks passed
@kddejong kddejong deleted the fix/issue/3916 branch January 17, 2025 18:31
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (5d9282d) to head (0e3e981).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
- Coverage   93.81%   93.81%   -0.01%     
==========================================
  Files         366      366              
  Lines       12536    12538       +2     
  Branches     2579     2580       +1     
==========================================
+ Hits        11761    11762       +1     
  Misses        429      429              
- Partials      346      347       +1     
Flag Coverage Δ
unittests 93.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E1011 "Is not one of" False Positive when AWS::Include transform is used in Mappings with other entries
1 participant