remove canvas issue workaround #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyiz-amzn
reviewed
Feb 4, 2025
| @@ -101,12 +101,6 @@ jobs: | |||
| with: | |||
| node-version: 18.x | |||
There was a problem hiding this comment.
A separate observation: With node18 installed, shall we remove L60?
There was a problem hiding this comment.
no node 15 is needed to run the cma script. node 18 is needed to use CW SDK.
ziyiz-amzn
approved these changes
Feb 4, 2025
georgezy-amzn
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Description
It seems these dependencies are not needed anymore.
Issue #, if available
Type of change
🧪 How Has This Been Tested?
ran daily test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.