Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autogenerated files from versioning #1562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dricross
Copy link
Contributor

Description of the issue

After running make test on a fresh repo, there will be some files that have been modified. These files are generated by certWatcher_test.go. They are used for the test and nothing else. They do not need to already exist for the test to pass. They do not need to be version controlled.

% git st
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   internal/tls/testdata/server.crt
        modified:   internal/tls/testdata/server.key
        modified:   internal/tls/testdata/tls-ca.crt

no changes added to commit (use "git add" and/or "git commit -a")

Description of changes

Remove autogenerated files from version control and ignore the autogenerated files

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

make test - no more modified files

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@dricross dricross requested a review from a team as a code owner February 21, 2025 21:21
Copy link
Contributor

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants