Migrate ECS client to aws-sdk-go-v2 in ecs-agent module #4485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate ECS client to aws-sdk-go-v2 in ecs-agent module.
#4406 added our bespoke codegen'd aws-sdk-go-v2 ECS client. This PR integrates the v2 ECS client with ecs-agent
Implementation details
In
go.mod
for theecs-agent
modules,github.com/aws/aws-sdk-go-v2/service/ecs
Update ECS client construction per the docs.
Replace all uses of our v1 ECS client with the v2 ECS client.
aws/aws-sdk-go/service/ecs
is now split betweenaws/aws-sdk-go-v2/service/ecs
andaws/aws-sdk-go-v2/service/ecs/types
.ContainerStateChange.NetworkBindings
changed from[]*NetworkBinding
to[]NetworkBinding
). See the docs for more info.int64
types are nowint32
(e.g.NetworkBinding.ContainerPort
andNetworkBinding.HostPort
changed from*int64
to*int32
).string
constants now have their own enum types aliased tostring
(e.g. theAgentUpdateStatus*
constants changed fromstring
to typeAgentUpdateStatus
.ErrCode*Exception
string constants have been replaced with Exception types (e.g.ErrCodeAccessDeniedException
("AccessDeniedException") now corresponds to theAccessDeniedException
type).Testing
GitHub checks pass.
New tests cover the changes:
Description for the changelog
Migrate ECS client to aws-sdk-go-v2 in ecs-agent module.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.