Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ECS client to aws-sdk-go-v2 in ecs-agent module #4485

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Yiyuanzzz
Copy link
Contributor

Summary

Migrate ECS client to aws-sdk-go-v2 in ecs-agent module.
#4406 added our bespoke codegen'd aws-sdk-go-v2 ECS client. This PR integrates the v2 ECS client with ecs-agent

Implementation details

In go.mod for the ecs-agent modules,

  1. add a dependency ongithub.com/aws/aws-sdk-go-v2/service/ecs
  2. add a replace directive so that we use our bespoke ECS package instead of the official SDK package
replace github.com/aws/aws-sdk-go-v2/service/ecs => ../aws-sdk-go-v2/service/ecs

Update ECS client construction per the docs.

Replace all uses of our v1 ECS client with the v2 ECS client.

Testing

GitHub checks pass.

New tests cover the changes:

Description for the changelog

Migrate ECS client to aws-sdk-go-v2 in ecs-agent module.

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Yiyuanzzz Yiyuanzzz requested a review from a team as a code owner January 29, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants