Allow create extra object(s) and use envFrom referencing configmap(s) / secret(s) in helm chart #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanzlik, Robert (MONETA) <[email protected]>
|
If this is for exposing https://repost.aws/knowledge-center/eks-http-proxy-configuration-automation Could you please verify this can be utilized. Previous issues / discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
Which issue does this PR fix?:
#3179
What does this PR do / Why do we need it?:
It adds ability ty create extra object like secret or configmap and use envFrom referencing configmap(s) / secret(s) in helm chart
Testing done on this change:
deployed on our EKS using changed helm chart, both added fields used.
Will this PR introduce any new dependencies?:
no
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
no, tested
Does this change require updates to the CNI daemonset config files to work?:
no
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.