Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename windows flags #371

Merged
merged 1 commit into from
Feb 20, 2024
Merged

rename windows flags #371

merged 1 commit into from
Feb 20, 2024

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Feb 20, 2024

Issue #, if available:
#370
Description of changes:
Current Windows' flags name can cause confusion for Linux users. We need rename them with prefix windows without breaking current users' setting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haouc haouc requested a review from a team as a code owner February 20, 2024 01:13
jdn5126
jdn5126 previously approved these changes Feb 20, 2024
Copy link
Contributor

@jdn5126 jdn5126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this so quickly! The changes look good to me, just one nit about adding another comment

pkg/config/loader.go Show resolved Hide resolved
@haouc haouc merged commit c10421f into aws:master Feb 20, 2024
3 checks passed
@sushrk sushrk linked an issue Feb 21, 2024 that may be closed by this pull request
yash97 pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Windows warm/minimum IP targets
2 participants