Support Security Group Name #410
Conversation
* sg name field in crd * add implementation * Move to getsgforVPC, move SG names into SG, unique items validation --------- Co-authored-by: Garvin Pang <[email protected]>
|
Hi @GnatorX, are you planning to add TTL cache changes in the same PR? |
|
I have added TTL cache. Sorry for the delay. |
| return securityGroup.securityGroupName, nil | ||
| } | ||
|
|
||
| securityGroupNameToIdCache := cache.NewTTLStore(securityGroupCacheKeyFunc, 15*time.Minute) |
There was a problem hiding this comment.
Note: The TTL duration could be made configurable by the user based on their use-case.
I'll discuss this internally with the team.
There was a problem hiding this comment.
@vgrigoruk did this get discussed internally?
|
Hi @GnatorX. Do you have time to follow up on the feedback provided? I'm very excited to see this feature in one of the next releases of AWS VPC CNI, so let me know if I can help picking it up from here. |
|
Ya I can do that. Sorry this is the same person as @GnatorX, sometimes I forget to switch between my accounts |
|
All comments addressed. Just need to know if we are interested in exposing the cache ttl |
|
@haouc Hey, is there someone from AWS side that can pick this back up? |
|
i dont think i have those powers. I know that sushrk is no longer at AWS however we would need someone else to pick this up from their side. |
sg name field in crd
add implementation
Move to getsgforVPC, move SG names into SG, unique items validation
Add TTL cache (15 minutes) to Security group name to ID calls to reduce calls to GetSecurityGroupForVPC
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.