chore(lambda-event-sources): expose arn and id for self-managed kafka source #31442
Conversation
…urceMappingId for SelfManagedKafkaEventSource
github-actions
bot
added
the
valued-contributor
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -950,53 +999,27 @@ describe('KafkaEventSource', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| test('consumerGroupId can be set for ManagedKafkaEventSource', () => { | |||
|
|
|||
| test('eventSourceMappingArn and eventSourceMappingId are defined', () => { | |||
There was a problem hiding this comment.
can you add test cases for the exception if the event source is not bound yet.
aws-cdk-automation
removed
the
pr/needs-community-review
|
could you please add a new GH issue as a Feature request, and link it to this issue. |
nikovirtala
changed the title
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
SelfManagedKafkaEventSourcedoesn't currently expose theeventSourceMappingArnoreventSourceMappingId, which makes e.g. granting privileges to those resources difficult.Description of changes
I exposed the
eventSourceMappingArnoreventSourceMappingIdthe same way it is done on theManagedKafkaEventSourceDescription of how you validated changes
The change is tested by adding similar unit tests to other event sources supporting this functionality.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license