feat(core): set (default) stack termination protection on (parent) stage level

[aripalo]

Issue #31449

Closes #31449.

Reason for this change

New feature: Enable setting Stack (default) termination protection on (parent) Stage level.

Description of changes

1. Introduce optional terminationProtection into StageProps
2. In Stage constructor, either use the termination protection value from its props (if set) or inherit from parent stage
3. In Stack constructor, either use the termination protection value from its props (if set), or inherit from parent stage, or finally default to false (as before)

Description of how you validated changes

I've originally done a PoC in my own codebase (by extending cdk.Stage).

After modifications into aws-cdk codebase:

• I've added new unit tests into:
  • packages/aws-cdk-lib/core/test/stage.test.ts
  • packages/aws-cdk-lib/core/test/stack.test.ts
• I've added new integ-test into packages/@aws-cdk-testing/framework-integ/test/core/test/integ.stage-termination-protection.ts and updated the snapshots

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

Disclaimers:

• This is my first code contribution to aws-cdk, apologies if I've missed something important
• I skipped the RFC process, because this is not a breaking change… but of course if required, I can open a new discussion too.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aripalo]

Well, now I've solved my integ-test setup, and it seems that the termination protection is not correctly inherit by the stack (from stage) yet – even though unit tests succeed. Will investigate.

Turns out I was looking the assertion stack data in the snapshot, not the test stack data which was correct (i.e. had a termination protection enabled) 😄

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f37d67e
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.