-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs-patterns): pidmode option for fargate services #31461
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
bbe0c95
to
f0a4d43
Compare
`pidMode` is an option of `FargateTaskDefinition`, but this was not exposed by `FargateTaskDefinition` which allows users to provide options for the `FargateTaskDefinition` that is created as part of a `*FargateService` when the `taskDefinition` property is excluded. If a user wanted to set the `pidMode` for their fargate tasks, it would require creating a separate `FargateTaskDefinition` construct and passing it to the `*FargateService` pattern. This change exposes this option directly so that users can specify a `pidMode` for their tasks without having to construct a separate `FargateTaskDefinition`. The associated `runtimePlatform.operatingSystemFamily` property which is required to be set to `ecs.OperatingSystemFamily.LINUX` when using `pidMode` was already exposed. Closes: aws#31412
f0a4d43
to
718c91d
Compare
Exemption Request Is it possible to get an exemption request for the integration test? This option already exists in the underlying constructs, and this PR just exposes it for convenience to the constructs in |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue
Closes #31412.
Reason for this change
pidMode
is an option ofFargateTaskDefinition
, but this was not exposed byFargateTaskDefinition
which allows users to provide options for theFargateTaskDefinition
that is created as part of a*FargateService
when thetaskDefinition
property is excluded. If a user wanted to set thepidMode
for their fargate tasks, it would require creating a separateFargateTaskDefinition
construct and passing it to the*FargateService
pattern.Description of changes
This change exposes this option directly so that users can specify a
pidMode
for their tasks without having to construct a separateFargateTaskDefinition
. The associatedruntimePlatform.operatingSystemFamily
property which is required to be set toecs.OperatingSystemFamily.LINUX
when usingpidMode
was already exposed.Description of how you validated changes
Added unit tests to ensure that the generated templates included the specified
PidMode
property. I've neglected to include integration tests, as I figured that the underlyingFargateTaskDefinition
constructs are already sufficiently tested.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license