chore(cognito-identitypool): refactor and remove Digits authentication provider

[Leo10Gama]

Issue # (if applicable)

N/A

Reason for this change

The authentication providers and their logic in this module have bad code smells, and thus, we have refactored them to bring the module more in line with CDK standards and best practices. In addition, the Digits authentication provider has been deprecated since September 2017, so it has been removed.

Description of changes

• Any modules relating to the Digits auth have been removed, as the service itself is deprecated.
• The IdentityPoolProviders and IdentityPoolAuthenticationProviders interfaces have been merged, as there did not seem to be a reason to keep them separate, aside from differentiating third-party and internal providers.
• Some grammar, punctuation, formatting, and capitalization changes

Description of how you validated changes

Unit tests and integration tests have been tweaked only as necessary to confirm these changes. Since they all still pass or show no need to be updated, we can confirm that this refactor does not affect them. The integration test has also been updated to reflect that the previous Google prop for clientSecret is deprecated, and use clientSecretValue instead.

BREAKING CHANGE: The IdentityPoolProviderType.DIGITS and IdentityPoolProviderUrl.DIGITS enum values, and IdentityPoolDigitsLoginProvider interface have been removed, as well as the digits attribute of the IdentityPoolAuthenticationProviders interface.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Leo10Gama]

Exemption Request - this is a refactor; seeing no changes to the integ tests is expected

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[comcalvi]

I don't think merging is worth it...we should ask customers to specify the name of the thing that they need to, not some arbitrary value that makes our lives easier, but not theirs.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Leo10Gama]

Will update the integ test, since trying to cdk deploy it (instead of yarn integ running it) gives the error:

[WARNING] aws-cdk-lib.aws_cognito.UserPoolIdentityProviderGoogleProps#clientSecret is deprecated.
  use clientSecretValue instead
  This API will be removed in the next major release.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[Leo10Gama]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codeql.yml without workflows permission

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5b5c7c4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.