Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to add references to EKS Auto Mode #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 24, 2025

Issue #, if available:

Description of changes:

update to add references to EKS Auto Mode

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tzneal tzneal requested a review from a team as a code owner March 24, 2025 14:39

You can protect your workloads from failures in an individual AZ by
running worker nodes and pods in multiple AZs. You can control the AZ
running worker nodes and Pods in multiple AZs. You can control the AZ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for the capitalization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream docs capitalize "Pod". If its standard here to lowercase, I can change it back.

https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroup.html[EC2
Auto Scaling groups] or community projects like
https://github.com/atlassian/escalator[Atlassian’s Escalator].
Auto Scaling groups].

== Recommendations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we think of any Auto Mode or Karpenter recommendations we can add back in here? It would be nice to have a POV on NodeGroup configurations (especially for multi-tenant clusters). Can you think of any universal advice we could add in?

@@ -197,129 +148,25 @@ spec:
Do not require that pods be scheduled across distinct AZs otherwise, the number of pods in a deployment will never exceed the number of AZs.
====

=== Ensure capacity in each AZ when using EBS volumes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer applicable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its automatic with Karpenter and Auto Mode.

@ricmattj
Copy link
Contributor

There's a lot of good changes in here, but I'm seeing the deletion of a ton of data plane best practices. We don't want to assume that everybody using the best practices guide is adopting auto mode. Unless I'm missing something, I'm thinking a lot of those that were deleted should stay put.

@geoffcline
Copy link
Collaborator

my perspective is that we should keep some of the content, but call out to migrate to auto mode

@geoffcline
Copy link
Collaborator

@ricmattj are you able to revise this based on the slack convo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants