-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to add references to EKS Auto Mode #657
base: master
Are you sure you want to change the base?
Conversation
|
||
You can protect your workloads from failures in an individual AZ by | ||
running worker nodes and pods in multiple AZs. You can control the AZ | ||
running worker nodes and Pods in multiple AZs. You can control the AZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for the capitalization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream docs capitalize "Pod". If its standard here to lowercase, I can change it back.
https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroup.html[EC2 | ||
Auto Scaling groups] or community projects like | ||
https://github.com/atlassian/escalator[Atlassian’s Escalator]. | ||
Auto Scaling groups]. | ||
|
||
== Recommendations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we think of any Auto Mode or Karpenter recommendations we can add back in here? It would be nice to have a POV on NodeGroup configurations (especially for multi-tenant clusters). Can you think of any universal advice we could add in?
@@ -197,129 +148,25 @@ spec: | |||
Do not require that pods be scheduled across distinct AZs otherwise, the number of pods in a deployment will never exceed the number of AZs. | |||
==== | |||
|
|||
=== Ensure capacity in each AZ when using EBS volumes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer applicable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its automatic with Karpenter and Auto Mode.
There's a lot of good changes in here, but I'm seeing the deletion of a ton of data plane best practices. We don't want to assume that everybody using the best practices guide is adopting auto mode. Unless I'm missing something, I'm thinking a lot of those that were deleted should stay put. |
my perspective is that we should keep some of the content, but call out to migrate to auto mode |
@ricmattj are you able to revise this based on the slack convo? |
Issue #, if available:
Description of changes:
update to add references to EKS Auto Mode
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.