Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: awscli arch is hardcoded (aarch64 broken) #370

Open
wants to merge 1 commit into
base: v2.8.1
Choose a base branch
from

Conversation

khannz
Copy link

@khannz khannz commented Apr 15, 2024

Issue #, if available: #358

Description of changes: Using standard way to detect ID of system architecture (uname -m), fix hardcoded x86_64 ID, which is not working for ARM architectures.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@miceg
Copy link

miceg commented Apr 18, 2024

Good tip, but this PR changes more than just fetching the correct architecture, and those changes aren't necessary:

  • The script uses set -e, so &&-chaining is redundant.
  • Using curl -P with a changing URL means you've needed to make all your later steps account for it. The existing curl -o means the awscli ZIP will always be written to the same spot, regardless of URL.

All you need to do to fetch the correct awscli architecture is a 1 line change from:

curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o $zip_file

to:

curl "https://awscli.amazonaws.com/awscli-exe-linux-$(uname -m).zip" -o $zip_file

You (or anyone else) are more than welcome to take this change for your own PR 😄

@greg-seesaw
Copy link

You (or anyone else) are more than welcome to take this change for your own PR 😄

FYI, looks like #332 does this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants