Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Warn about SSL Certificate verification being disabled only when it's actually disabled #6005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsmelo
Copy link

@bsmelo bsmelo commented Apr 3, 2025

Motivation and Context

Initializing a CRT-based S3AsyncClient with .httpConfiguration(c -> c.trustAllCertificatesEnabled(ignoreCertificate)) (ignoreCertificate being a client-configured flag), works well for setting ignoreCertificate = Boolean.TRUE during tests. However, changing such flag to Boolean.FALSE didn't make the warning message go away, even though SSL Certificate was verified in this last case. The warning message turns out misleading in this case.

Modifications

Basically, only Boolean.TRUE disables SSL Certificate Validation, so both null as well as Boolean.FALSE should skip the warning message.

Testing

Since it's just a ternary Boolean check, I've just verified the state of clientTlsContextOptions.verifyPeer right after the if statement with a debugger.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

… it's actually disabled

Only Boolean.TRUE disables SSL Certificate Validation, so both Boolean.FALSE and null should skip the warning message
@bsmelo bsmelo requested a review from a team as a code owner April 3, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant