chore(middleware-flexible-checksums): use RequestChecksumCalculation and ResponseChecksumValidation

[trivikr]

Issue

• Internal
• Alternative to chore(middleware-flexible-checksums): use RequestChecksumCalculation and ResponseChecksumValidation without interceptor middleware #6484 with flexibleChecksumsInterceptorMiddleware

Description

• Uses values in RequestChecksumCalculation and ResponseChecksumValidation to decide flexible checksums algorithm.
• Adds flexibleChecksumsInterceptorMiddleware to populate input[requestValidationModeMember]
• Deprecates MD5, and sets CRC32 as default.

Testing

Unit testing in CI

Also, verified that checksums are computed by default

import { S3 } from "../aws-sdk-js-v3/clients/client-s3/dist-cjs/index.js";
import { NodeHttpHandler } from "@smithy/node-http-handler";

class CustomHandler extends NodeHttpHandler {
  constructor() {
    super();
  }

  async handle(request, options) {
    for (const [header, value] of Object.entries(request.headers)) {
      if (header.startsWith("x-amz-checksum-")) {
        console.log(`request['${header}']: '${value}'`);
      }
    }
    const response = await super.handle(request, options);
    for (const [header, value] of Object.entries(response.response.headers)) {
      if (header.startsWith("x-amz-checksum-")) {
        console.log(`response['${header}']: '${value}'`);
      }
    }
    return response;
  }
}

// WHEN_SUPPORTED is default.
const client = new S3({
  requestHandler: new CustomHandler(),
});

console.log("Put Object");
await client.putObject({
  Bucket: "test-flexible-checksums-v2",
  Key: "hello-world.txt",
  Body: "Hello World",
});

console.log("\nGet Object");
await client.getObject({
  Bucket: "test-flexible-checksums-v2",
  Key: "hello-world.txt",
});

console.log("");
console.log(await Body.transformToString());

Output

Put Object
request['x-amz-checksum-crc32']: 'ShexVg=='
response['x-amz-checksum-crc32']: 'ShexVg=='

Get Object
request['x-amz-checksum-mode']: 'ENABLED'
request['x-amz-checksum-crc32']: 'AAAAAA=='
response['x-amz-checksum-crc32']: 'ShexVg=='

Hello World

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[trivikr]

The PR is ready for review. It's marked as draft, as it shouldn't be merged at this time.

[kuhe]

what happens if the if conditions are true but input[requestValidationModeMember] is set by the user to some other value than ENABLED (ignoring the fact that this is the only enum value)?

I would expect us to allow the value through and allow the user to receive a validation exception from the server.