fix: Update AwsException constructor to accept Throwable instead of Exception #2990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the
AwsException
constructor to accept aThrowable
instead of anException
as the$previous
parameter. This change ensures that all types of throwable errors, includingError
andException
, are properly handled and passed to theAwsException
.Changes
AwsException
constructor to accept\Throwable
for the$previous
parameter.Why this change?
Previously, the
AwsException
constructor only acceptedException
as the$previous
parameter, which caused issues when other types of throwables, likeError
, were passed. By acceptingThrowable
, we ensure a more robust and flexible error handling process.Testing
Impact
This change enhances the SDK's error-handling capabilities without introducing breaking changes, ensuring better compatibility with a wider range of PHP error types.