-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazonq): Add lsp downloading support for windows/linux #6325
base: feature/amazonqLSP
Are you sure you want to change the base?
feat(amazonq): Add lsp downloading support for windows/linux #6325
Conversation
|
return path.join(os.homedir(), 'Library/Application Support') | ||
} | ||
case 'win32': { | ||
return process.env.APPDATA | ||
} | ||
case 'linux': { | ||
return process.env.XDG_CACHE_HOME || path.join(os.homedir(), '.cache') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use fs.getUserHomeDir
, it handles some edge cases.
getUserHomeDir(): string { |
getApplicationSupportFolder
should live in fs.ts
(and that makes sense anyways, because this is a filesystem decision).
It also seems like getApplicationSupportFolder
is getting a cache dir, so maybe getCacheDir
is a good name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tryGetFilepathEnvVar
may also be worth looking at in the future.
async tryGetFilepathEnvVar(envVar: string, kind: vscode.FileType | undefined): Promise<string | undefined> { |
Problem
Solution
feature/x
branches will not be squash-merged at release time.