Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Add lsp downloading support for windows/linux #6325

Open
wants to merge 1 commit into
base: feature/amazonqLSP
Choose a base branch
from

Conversation

jpinkney-aws
Copy link
Contributor

Problem

  • Language servers are only being downloaded on macs

Solution

  • Download on windows/linux as well

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner January 9, 2025 13:28
Copy link

github-actions bot commented Jan 9, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Comment on lines 278 to +284
return path.join(os.homedir(), 'Library/Application Support')
}
case 'win32': {
return process.env.APPDATA
}
case 'linux': {
return process.env.XDG_CACHE_HOME || path.join(os.homedir(), '.cache')
Copy link
Contributor

@justinmk3 justinmk3 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use fs.getUserHomeDir, it handles some edge cases.

getUserHomeDir(): string {
And to avoid the circular dependency, getApplicationSupportFolder should live in fs.ts (and that makes sense anyways, because this is a filesystem decision).

It also seems like getApplicationSupportFolder is getting a cache dir, so maybe getCacheDir is a good name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tryGetFilepathEnvVar may also be worth looking at in the future.

async tryGetFilepathEnvVar(envVar: string, kind: vscode.FileType | undefined): Promise<string | undefined> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants