Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Adding diff view UX for generated files in Agentic chat #6876

Merged
merged 8 commits into from
Mar 31, 2025

Conversation

laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Mar 28, 2025

Problem

  • Existing UX accepts the generated files without permission check.

Solution

  • Added code diff view using VSC native diff functionality, Users can click on the generated files and see the code diff.
  • Users can now accept/reject the generated code.
  • Close the diff view once user clicks on Accept or Reject.
  • Fix: If user clicks on Confirm button to execute the bash command change this to Confirmed state.
  • In read tool execution and safe bash command execution use different id: generic-tool-execution in processCustomFormAction as this helps the above step to execute.
  • Fix: Removing the Q spinner component if user clicks on reject button or code diff filePath.
Screen.Recording.2025-03-27.at.10.02.27.PM.mov

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@laileni-aws laileni-aws marked this pull request as ready for review March 28, 2025 04:41
@laileni-aws laileni-aws requested a review from a team as a code owner March 28, 2025 04:41
@laileni-aws laileni-aws requested a review from ammathu March 28, 2025 05:22
@laileni-aws laileni-aws requested a review from a team as a code owner March 28, 2025 13:26
@laileni-aws laileni-aws requested a review from ctlai95 March 28, 2025 17:20
@laileni-aws
Copy link
Contributor Author

/retryBuilds

@laileni-aws
Copy link
Contributor Author

/retryBuilds

@laileni-aws laileni-aws requested a review from zixlin7 March 31, 2025 21:36
@zixlin7 zixlin7 merged commit eed4803 into aws:feature/agentic-chat Mar 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants