Fix testPatternPermutations within ByteMachingTest #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each test within the class we add a list of "noMatches" objects that should never be pattern matches intentinoally or not. However we never check if we ever accidentally register these pattern when adding other patterns. We will fix this by tracking when these patterns get added (probably by error) and then later validate the checks Note, no impact to the correctness of the ByteMachine itself, just that the test scaffolding was broken and needed to be fixed. See #181 for more context.
timbray
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 181
Description of changes:
For each test within the class we add a list of "noMatches" objects that should never be pattern matches intentinoally or not. However we never check if we ever accidentally register these pattern when adding other patterns. We will fix this by tracking when these patterns get added (probably by error) and then later validate the checks
Note, no impact to the correctness of the ByteMachine itself, just that the test scaffolding was broken and needed to be fixed.
See #181 for more context.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.