-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Create core integ tests folder and setup #4505
base: master
Are you sure you want to change the base?
Conversation
Moved few integration tests to core folder this subset will be run for every pull request to increase velocity of the pull requests independent contributors must still run the entire test suite added python 3.11 to the setup.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4505 +/- ##
==========================================
+ Coverage 87.34% 87.35% +0.01%
==========================================
Files 388 389 +1
Lines 36545 36631 +86
==========================================
+ Hits 31921 32000 +79
- Misses 4624 4631 +7 ☔ View full report in Codecov by Sentry. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
def pytest_collection_modifyitems(config, items): | ||
for item in items: | ||
if "tests/integ/core" in str(item.fspath): | ||
item.add_marker(pytest.mark.core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this we can do tox -e py310 -- test/integ -m core
?
Idea being that we'll be able to split things up here and later on in our buildspec do
tox -e py310 -- test/integ -m $SUB_TESTS
where we pass $SUB_TESTS
(or whatever we call it) as an environment variable from our github actions yml. In this case we could set SUB_TESTS='core'
to only run core tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! that's correct.
This is applied as a filter after pytest performs collection and adds a marker to the tests that are in this directory.
Locally the collection runs quickly <3mins
pytest tests/integ --collect-only --quiet -m core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicee
Can you take a look at this PR again? Some conflicts |
Issue #, if available:
Description of changes:
Moved few integration tests to core folder
this subset will be run for every pull request
to increase velocity of the pull requests
independent contributors must still run the entire test suite
added python 3.11 to the setup.py
Testing done:
run locally and via PR
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.