Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecation warnings for RL #4578

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jinyoung-lim
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jinyoung-lim jinyoung-lim requested a review from a team as a code owner April 12, 2024 21:10
@jinyoung-lim jinyoung-lim requested review from akrishna1995 and removed request for a team April 12, 2024 21:10
JGuinegagne
JGuinegagne previously approved these changes Apr 12, 2024
deprecation_warn(
"SageMaker-hosted RL images no longer accept new pull requests and",
"April 2024",
" Please pass in `image_uri` to use RLEstimator"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tech writer do not like using Please do x in customer messaging, could you ping @judyheflin for review before merging?

knikure
knikure previously approved these changes Apr 16, 2024
@knikure
Copy link
Contributor

knikure commented Apr 16, 2024

@jinyoung-lim Can you please resolve the code-style issues?

@knikure
Copy link
Contributor

knikure commented Apr 17, 2024

@jinyoung-lim Could you pls fix the codestyle? https://github.com/aws/sagemaker-python-sdk/actions/runs/8724972624/job/23936838151?pr=4578
Run tox -e black-format to fix black issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants