Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix model reference train by excluding certian keys from camelization #4829

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bencrabtree
Copy link
Collaborator

@bencrabtree bencrabtree commented Aug 13, 2024

Issue #, if available:

Description of changes:
When initializing the JumpStartEstimator class, it throws an error while initializing the metric definitions

    847 for metric_definition in default_metric_definitions:
--> 848     if metric_definition["Name"] not in {
    849         definition["Name"] for definition in kwargs.metric_definitions
    850     }:
    851         kwargs.metric_definitions.append(metric_definition)

KeyError: 'Name'

I tried printing out the default_metric_definitions for the ModelReference and got the following:

[{'name': 'huggingface-textgeneration:eval-loss',
  'regex': "'eval_loss': ([0-9]+\\.[0-9]+)"},
 {'name': 'huggingface-textgeneration:train-loss',
  'regex': "'loss': ([0-9]+\\.[0-9]+)"}]

When I tried printing out the same for the base Model, I got this:

[{'Name': 'huggingface-textgeneration:eval-loss',
  'Regex': "'eval_loss': ([0-9]+\\.[0-9]+)"},
 {'Name': 'huggingface-textgeneration:train-loss',
  'Regex': "'loss': ([0-9]+\\.[0-9]+)"}]

Testing done:

  • Unit tests
  • Created TrainingJob locally with the existing code

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

evakravi
evakravi previously approved these changes Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants