Master #5112
Merged
Master #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evakravi
reviewed
Apr 1, 2025
| """Get access configs | ||
|
|
||
| Args: | ||
| accept_eula (Optional[bool]): Whether or not the EULA was accepted, optionally passed in to Estimator.fit(). | ||
| """ | ||
| env_var_eula = environment.get("accept_eula") | ||
| if env_var_eula and accept_eula is not None: | ||
| raise ValueError( |
Narrohag
approved these changes
Apr 1, 2025
evakravi
reviewed
Apr 1, 2025
| if accept_eula is not None and init_kwargs["environment"]: | ||
| del init_kwargs["environment"][constants.SAGEMAKER_GATED_MODEL_S3_URI_TRAINING_ENV_VAR_KEY] | ||
| if accept_eula is not None and init_kwargs.get("environment") is not None: | ||
| if ( |
There was a problem hiding this comment.
nit: you can do init_kwargs["environment"].pop(constants.SAGEMAKER_GATED_MODEL_S3_URI_TRAINING_ENV_VAR_KEY, None)
varunmoris
approved these changes
Apr 1, 2025
evakravi
previously approved these changes
Apr 1, 2025
Narrohag
reviewed
Apr 1, 2025
src/test.py
Outdated
There was a problem hiding this comment.
think this crept in accidentally
mollyheamazon
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
hyperparameters.retrieve_defaultwith hub_name param that is not in ARN format (accessors.py)Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.