Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mlflow tracking arn telemetry #5113

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

ruiliann666
Copy link
Contributor

Issue #, if available:
Action items from: https://t.corp.amazon.com/P208359337

We will append the MLFlow tracking arn to our ModelBuilder PythonSDK telemetry mechanism along with EndpointName to BI for revenue tracking from the ModelBuilder specifically.

Description of changes:
Add MLflow tracking arn to the extra info in telemetry

Testing done:
Ran unit tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruiliann666 ruiliann666 requested a review from a team as a code owner April 2, 2025 22:34
@ruiliann666 ruiliann666 requested a review from liujiaorr April 2, 2025 22:34
gwang111
gwang111 previously approved these changes Apr 2, 2025
Copy link
Collaborator

@gwang111 gwang111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Ruilian

Copy link

@wutimot wutimot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mollyheamazon mollyheamazon merged commit 7fc9868 into aws:master Apr 3, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants