-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Account Id to Credentials #260
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 80.41% 80.50% +0.09%
==========================================
Files 33 33
Lines 6019 6099 +80
==========================================
+ Hits 4840 4910 +70
- Misses 1179 1189 +10 ☔ View full report in Codecov by Sentry. |
.github/workflows/codecov.yml
Outdated
@@ -28,4 +28,4 @@ jobs: | |||
run: | | |||
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')" | |||
chmod a+x builder | |||
./builder build -p ${{ env.PACKAGE_NAME }} --compiler=gcc-9 --cmake-extra=-DASSERT_LOCK_HELD=ON --coverage | |||
./builder build -p ${{ env.PACKAGE_NAME }} --compiler=gcc-12 --cmake-extra=-DASSERT_LOCK_HELD=ON --coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? Add some comments about this?
Do we need it to be applied to other codecov jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the comment. Yes, we need to fix it everywhere where we updated the code coverage action ubuntu version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm looks like the ci before the commit changing the compiler still work? https://github.com/awslabs/aws-c-auth/actions/runs/12757805423/job/35558824650
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you expand the build step and scroll to the end, you can see the errors. No idea why the overall CI says success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, maybe instead of updating the gcc version for every codecov ci, we should update our builder
We install our own version of gcc, but the ctest -T coverage
probably still use the default one in the system.
Seems like we can pass --gcov
to chose what version of gcov to solve the version mismatch thing. https://stackoverflow.com/questions/12454175/gcov-out-of-memory-mismatched-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed by awslabs/aws-crt-builder#317.
Issue #, if available:
awslabs/aws-crt-swift#303
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.