Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of gcc compiler default case #317

Merged
merged 12 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sanity-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ jobs:
- musllinux-1-1-x64

needs: package
runs-on: ubuntu-24.04
runs-on: ubuntu-22.04 # temporarily downgrade to old ubuntu as 24.04 likes to segfault in the middle of the build
steps:
- uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
6 changes: 6 additions & 0 deletions builder/core/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,12 @@ class PKG_TOOLS(Enum):
'yum_compiler_packages': ['gcc', 'gcc-c++'],

'versions': {
'default': {
'!c': "gcc",
'!cxx': "g++",
'!compiler_packages': [],
'!apt_compiler_packages': [],
},
'4.8': {
# ASan has been broken on 4.8 GCC version distributed on Ubuntu
# and will unlikely to get fixed upstream. so turn it off.
Expand Down