Cognito credential provider support #306
Conversation
| @@ -0,0 +1,9 @@ | |||
| import Builder | |||
|
|
|||
| class CrtCiPrepXCodebuild(Builder.Action): | |||
There was a problem hiding this comment.
I haven't looked at the PR but can we avoid adding this action in crt-swift? We don't need to test the Cognito credential provider functionality in bindings; we can just create/destroy it for simple binding tests. The MQTT-specific tests should be in the IoT SDK.
This action makes it harder to run these tests locally. I think we will likely need this action for MQTT unit tests but we should try to avoid it if possible.
There was a problem hiding this comment.
This script change is used to allow passing environment variables into xcodebuild tests. Regardless of the Cognito credential provider changes, we still need it for the unit tests that requires environment variables.
xiazhvera
changed the title
xiazhvera
changed the title
| @@ -76,7 +138,7 @@ extension CredentialsProvider { | |||
| } | |||
|
|
|||
| extension CredentialsProvider.Source { | |||
|
|
|||
There was a problem hiding this comment.
There are a large number of weird white space additions onto empty lines. Is this an auto formatting issue?
Issue #, if available:
Description of changes:
The PR added support for cognito credential provider.
It also depends on latest crt-builder to enable the environment variables for xcodebuild test. awslabs/aws-crt-builder#314
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.